Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in the perf_csi function #74

Open
vancities opened this issue May 3, 2021 · 0 comments
Open

Bug in the perf_csi function #74

vancities opened this issue May 3, 2021 · 0 comments

Comments

@vancities
Copy link

vancities commented May 3, 2021

image

highlighted code won't assign the value to the y column. It will raise key_error of y later.

However, with y being NaN,
distr_prob = dat.groupby(['ae', 'bin'])\ ['y'].agg([good, bad])\ .assign(N=lambda x: x.good+x.bad, badprob=lambda x: x.bad/(x.good+x.bad) ).reset_index()
won't have distr attribute at the step of ploting.

Normally, PSI won't require label data and plot should still be okay to have without the line-plot of bad probability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant