Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

woebin_ply bug #73

Open
GISH123 opened this issue Mar 19, 2021 · 2 comments
Open

woebin_ply bug #73

GISH123 opened this issue Mar 19, 2021 · 2 comments

Comments

@GISH123
Copy link

GISH123 commented Mar 19, 2021

When applying woebin into a dataframe, there is a occasional bug that happens if:

  1. that feature has missing value;
  2. in woebin, you make a bin with special value = 0

Example:
a
This feature will be ok applying on a dataframe, since it has no special value

!However, the following two feature:
b
If the to-be-applied dataframe has value 0, it will be given woe = -0.841608( [-inf,0.1) bin ) which is false
should be 0.529374 instead.

I kind of quick fixed by trying to force where my original data value = 0, I give it the true woe value(0.529374) instead.
image

Summary in traditional chinese:
簡單來說就是如果該dataframe,該特徵有missing value且在woebin有設定special value = 0,則所有0會被給予下一個(bin)分箱的值

@ShichenXie
Copy link
Owner

I know the woebin_adj function is not so stable. I'll fix it if I have time in the future.
You can try to use the R version package which is much mature.

@GISH123
Copy link
Author

GISH123 commented Mar 22, 2021

Well, at least outside of this particular problem, the woebin_adj work wonders.
Quickfixing it doesn't take much time too.
Thank you for your reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants