Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with map #176

Open
jet1992 opened this issue Feb 7, 2023 · 2 comments
Open

Problem with map #176

jet1992 opened this issue Feb 7, 2023 · 2 comments

Comments

@jet1992
Copy link

jet1992 commented Feb 7, 2023

Hello, here is problem using smidge when map(//# sourceMappingURL=url) is in js/css file and we want to have that line because if version changed etc it has by default, but we don't using map files.
image
Smidge throws error: Could not parse {bundleId} as a valid smidge path
image
And
image
I think here better solution would be if BundleRequestModel returns empty bundle and then in controller:
image
It will be like now returns no page found(because first if will return true) and will be better solution, because returning error in BundleRequestModel flooding logs. So better solution I think not to check if bundle exists in BundleRequestModel, but return not found page. And error code 404 is better for this issue I think

@Shazwazza
Copy link
Owner

Hi, thanks for the report. Would it be possible for you to create a PR to address this?

@jet1992
Copy link
Author

jet1992 commented Feb 11, 2023

Hi, ok, I will try to create

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants