Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change single quotes to double quotes in HTML output #141

Open
craigs100 opened this issue Dec 31, 2021 · 3 comments
Open

Change single quotes to double quotes in HTML output #141

craigs100 opened this issue Dec 31, 2021 · 3 comments

Comments

@craigs100
Copy link
Contributor

Just noticed the Smidge output uses single quotes in HTML rather than double.

I know both are technically legal but I also know that many people use double quotes in HTML and single quotes in JS. Any chance they could be changed? So this: <link href='/sc/69a3dbf6.1cf661e7.css.v100' rel='stylesheet' type='text/css'/> becomes this: <link href="/sc/69a3dbf6.1cf661e7.css.v100" rel="stylesheet" type="text/css"> (note the forward slash is also removed as it's no longer necessary in HTML5 AFAIK. You could probably remove the "type" attribute as well).

Thnx

@Shazwazza
Copy link
Owner

Hi @craigs100 ! That can be done :) It would be super awesome if you'd be able to submit a PR with the change and then I can get another release out once it's merged. Do you think you'd be able to help?

@craigs100
Copy link
Contributor Author

PR submitted but not tested ( I don't have the chops for that ;) )

@Shazwazza
Copy link
Owner

Awesome! All looks good, i just added one question on the PR for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants