fix: use favicon.ico instead of /static/favicon-32x32.png

SharzyL · SharzyL · commit 11df72bcc1a9 · 2025-04-28T13:35:24.000+08:00
diff --git a/frontend/index.html b/frontend/index.html
@@ -2,7 +2,7 @@
 <html lang="en">
   <head>
     <meta charset="UTF-8" />
-    <link rel="icon" type="image/png" href="/static/favicon-32x32.png" />
+    <link rel="icon" type="image/png" href="favicon.ico" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>%INDEX_PAGE_TITLE%</title>
   </head>
diff --git a/frontend/public/favicon.ico b/frontend/public/favicon.ico
diff --git a/src/handlers/handleRead.ts b/src/handlers/handleRead.ts
@@ -52,7 +52,7 @@ async function handleStaticPages(request: Request, env: Env, _: ExecutionContext
   } else if (path.lastIndexOf("/") === 0 && path.indexOf(":") > 0) {
     path = "/index.html" // handle admin URL
   }
-  if (path.startsWith("/assets/") || path.startsWith("/static/") || path === "/index.html") {
+  if (path.startsWith("/assets/") || path === "/favicon.ico" || path === "/index.html") {
     if (path === "/index.html") {
       const authResponse = verifyAuth(request, env)
       if (authResponse !== null) {
diff --git a/test/basicAuth.spec.ts b/test/basicAuth.spec.ts
@@ -1,5 +1,5 @@
 import { expect, test } from "vitest"
-import { areBlobsEqual, BASE_URL, createFormData, genRandomBlob, staticPages, workerFetch } from "./testUtils.js"
+import { areBlobsEqual, BASE_URL, createFormData, genRandomBlob, workerFetch } from "./testUtils.js"
 import { encodeBasicAuth, decodeBasicAuth } from "../src/auth.js"
 import { createExecutionContext, env } from "cloudflare:test"
 import { PasteResponse } from "../src/shared"
@@ -32,7 +32,7 @@ test("basic auth", async () => {
   env.BASIC_AUTH = users
 
   // access index page
-  for (const page of staticPages) {
+  for (const page of ["", "index", "index.html"]) {
     expect((await workerFetch(ctx, `${BASE_URL}/${page}`)).status).toStrictEqual(401)
   }
   expect(
diff --git a/test/testUtils.ts b/test/testUtils.ts
@@ -9,7 +9,7 @@ import { PasteResponse } from "../src/shared"
 export const BASE_URL: string = env.DEPLOY_URL
 export const RAND_NAME_REGEX = /^[ABCDEFGHJKMNPQRSTWXYZabcdefhijkmnprstwxyz2345678]+$/
 
-export const staticPages = ["", "index.html", "index", "tos", "tos.html", "api", "api.html"]
+export const staticPages = ["", "index.html", "index", "tos", "tos.html", "api", "api.html", "favicon.ico"]
 
 type FormDataBuild = {
   [key: string]: string | Blob | { content: Blob; filename: string }
diff --git a/worker-configuration.d.ts b/worker-configuration.d.ts
@@ -1,13 +1,13 @@
 /* eslint-disable */
-// Generated by Wrangler by running `wrangler types --strict-vars false` (hash: 6b22c42e567b3c204913f826b6198cca)
+// Generated by Wrangler by running `wrangler types --strict-vars false` (hash: 10ab9202aff10f1034182c3c5aea97a8)
 // Runtime types generated with workerd@1.20250424.0 2025-04-24 
 declare namespace Cloudflare {
 	interface Env {
 		PB: KVNamespace;
 		DEPLOY_URL: string;
 		REPO: string;
-		TOS_MAINTAINER: string;
 		INDEX_PAGE_TITLE: string;
+		TOS_MAINTAINER: string;
 		TOS_MAIL: string;
 		CACHE_STATIC_PAGE_AGE: number;
 		CACHE_PASTE_AGE: number;

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ async function handleStaticPages(request: Request, env: Env, _: ExecutionContext`
`52`	`52`	`} else if (path.lastIndexOf("/") === 0 && path.indexOf(":") > 0) {`
`53`	`53`	`path = "/index.html" // handle admin URL`
`54`	`54`	`}`
`55`		`- if (path.startsWith("/assets/") \|\| path.startsWith("/static/") \|\| path === "/index.html") {`
	`55`	`+ if (path.startsWith("/assets/") \|\| path === "/favicon.ico" \|\| path === "/index.html") {`
`56`	`56`	`if (path === "/index.html") {`
`57`	`57`	`const authResponse = verifyAuth(request, env)`
`58`	`58`	`if (authResponse !== null) {`