Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MP4: Move major brand to Mp4Properties #287

Open
Serial-ATA opened this issue Nov 2, 2023 · 0 comments
Open

MP4: Move major brand to Mp4Properties #287

Serial-ATA opened this issue Nov 2, 2023 · 0 comments
Labels
enhancement New feature or request good first issue These issues are a good way to get started with Lofty

Comments

@Serial-ATA
Copy link
Owner

The major brand is kept in Mp4File for some reason.

https://github.com/Serial-ATA/lofty-rs/blob/main/src/mp4/mod.rs#L34-L35

The field, along with its getter, should be moved to Mp4Properties.
@Serial-ATA Serial-ATA added enhancement New feature or request good first issue These issues are a good way to get started with Lofty labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue These issues are a good way to get started with Lofty
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Serial-ATA