Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseOptions: Add read_tags #251

Open
Serial-ATA opened this issue Sep 12, 2023 · 0 comments
Open

ParseOptions: Add read_tags #251

Serial-ATA opened this issue Sep 12, 2023 · 0 comments
Labels
enhancement New feature or request good first issue These issues are a good way to get started with Lofty help wanted Extra attention is needed

Comments

@Serial-ATA
Copy link
Owner

Summary

Unexpectedly, many projects pull in Lofty solely for its property reading. Each time it is used for this purpose, however, all of the tags are still being parsed unnecessarily.

Just as one can skip property reading with ParseOptions::read_properties(false), it may be worth adding ParseOptions::read_tags().

API design

impl ParseOptions {
    pub fn read_tags(&mut self, read_tags: bool) -> Self;
}
@Serial-ATA Serial-ATA added enhancement New feature or request help wanted Extra attention is needed good first issue These issues are a good way to get started with Lofty labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue These issues are a good way to get started with Lofty help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant