Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose tag parsing internals #206

Open
Serial-ATA opened this issue Jun 3, 2023 · 0 comments
Open

Expose tag parsing internals #206

Serial-ATA opened this issue Jun 3, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Serial-ATA
Copy link
Owner

It may not always be convenient to read an entire file. At this point, the tag parsing internals change infrequently enough that it'd probably be safe to expose them.

It'd be nice to make all of the parse functions have a similar signature to parse_id3v2:

pub(crate) fn parse_id3v2<R>(
bytes: &mut R,
header: Id3v2Header,
parse_mode: ParsingMode,
) -> Result<Id3v2Tag>
where
R: Read,
{

Some still have unnecessary Seek bounds or are just too clunky to use externally in their current state (like VorbisComments).

@Serial-ATA Serial-ATA added the enhancement New feature or request label Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant