Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack DXC as libs instead of resources to avoid IO from generator #348

Open
Sergio0694 opened this issue Aug 14, 2022 · 0 comments · May be fixed by #349
Open

Pack DXC as libs instead of resources to avoid IO from generator #348

Sergio0694 opened this issue Aug 14, 2022 · 0 comments · May be fixed by #349
Labels
enhancement ✨ An improvement to existing APIs optimization 🚀 Performance improvement to existing APIs

Comments

@Sergio0694
Copy link
Owner

Sergio0694 commented Aug 14, 2022

Description

The ComputeSharp generator is currently bundling the DXC libs as embedded resources, then unpacking them to a temporary folder and loading them from there. This adds extra complexity and most importantly means the generator has to do IO, which should instead be avoided. The generator should be updated so that the DXC libs are packed as dependencies for the generator assembly and copied to the same output folder, so they can be loaded directly from there (which is fine), without having to do that extra step with IO first (which also means it'll be a bit faster to load as well).

See dotnet/roslyn#63290 and dotnet/roslyn#54899

@Sergio0694 Sergio0694 added enhancement ✨ An improvement to existing APIs optimization 🚀 Performance improvement to existing APIs labels Aug 14, 2022
@Sergio0694 Sergio0694 linked a pull request Aug 14, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ An improvement to existing APIs optimization 🚀 Performance improvement to existing APIs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant