Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ladybird: div opacity in conjunction with float:left on ul #23944

Open
zppln opened this issue Apr 12, 2024 · 1 comment
Open

Ladybird: div opacity in conjunction with float:left on ul #23944

zppln opened this issue Apr 12, 2024 · 1 comment

Comments

@zppln
Copy link

zppln commented Apr 12, 2024

Pardon the convoluted title... But, I noticed on Flashback that the user stats displayed below the logo on top wouldn't show up in Ladybird. I've tried to make a reduction and came up with the following:

<body>
  <div style="opacity:.95;border:1px solid red">
    div text
    <ul style="float:left;border:1px solid green">ul text</ul>
  </div>
</body>

Which renders as follows:

Firefox:
flashback_firefox

Ladybird:
flashback_ladybird

I could take a stab at this if this could be considered a good first issue. :)
@zppln
Copy link
Author

zppln commented Apr 15, 2024 •
edited

Did some more digging: if I remove the opacity property the rendering looks about the same as Firefox, but the Layout Tree and Paint Tree remains the same as before. However, the Stacking Context Tree gets an additional BlockContainer<Div> node (where with the opacity property there are only two nodes: Viewport<#document> and BlockContainer<HTML>).

zppln added a commit to zppln/serenity that referenced this issue Apr 17, 2024
@zppln
LibWeb: Fix user stats on flashback.org
fc06189 
This "fix" makes the user stats below the logo on flashback.org
show up.

This fixes SerenityOS#23944
@zppln zppln mentioned this issue Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LibWeb: Fix user stats on flashback.org zppln/serenity
1 participant
@zppln