Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment fails with node v18.18.0 #1017

Open
trflynn89 opened this issue Nov 1, 2023 · 1 comment
Open

Deployment fails with node v18.18.0 #1017

trflynn89 opened this issue Nov 1, 2023 · 1 comment

Comments

@trflynn89
Copy link
Member

See 3c5e0ab

Node v18.18.0 includes an update to npm 9.7.2:
nodejs/node@4a6177d

That update removes the node-gyp executable. Without it, we get the following error when deploying the Heroku app:

Failed to auto-install node-gyp. Please run "yarn global add node-gyp" manually.

I'm not sure how do to the recommended step because this runs remotely in Heroku's servers (i.e. I don't think adding it as a step in the GitHub workflow will suffice).

For now, this has been worked around by limiting node to v18.17.1.

@bgianfo
Copy link
Member

bgianfo commented Dec 12, 2023

There is a very ominous note here: https://devcenter.heroku.com/articles/cli-style-guide#native-dependencies

Native dependencies
The Heroku CLI does not support native dependencies. They will break when we update the node version. Also, native dependencies typically require the use of node-gyp, which requires Python, and generally is likely to have problems compiling on all user environments, especially Windows.

I'm not sure how this can be true, as... like the entire ecosystem depends on this stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants