Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Fork Problem #4

Closed
code-Gambler opened this issue Apr 19, 2024 · 7 comments
Closed

Github Fork Problem #4

code-Gambler opened this issue Apr 19, 2024 · 7 comments
Assignees

Comments

@code-Gambler
Copy link
Collaborator

Hello @ctyler @MatthewDeNapoli ,

I was helping out Travis in creating a pull request to this repository, but he was not able to do so as this a fork of gcc-mirror not a standalone repository. I can create a pull request between my fork and this repo only because I have write access. I am pretty sure if we provide write access to travis, he would be able to create a pull request, but we cannot give out write accesses to all the people contributing to this repo. I found a community post which explains how to detach a fork, so that it becomes a standalone fork for experimentation purposes here. One of us (you, me or anyone with write access can do it) needs to go here and do it and may be that solves the problem.

Recreation (Account used doesn't have write access to this repo)
image

Click on the pull request button

image

As we can see the default base repository is gcc-mirror/gcc

image

Even if we search for Seneca-CDOT's fork it doesn't show up.

Here is an example of PR from my account which has write access:

image

Please advise.

@MatthewDeNapoli
Copy link
Collaborator

Hello,

Make sure when creating the pull request you start off on the fork that's been created.
This is so you can specify the source as the fork Travis has created and the destination as the Seneca-CDOT repository.
If you have any other questions or need any help feel free to leave a comment.

Ex.
image

@code-Gambler
Copy link
Collaborator Author

I think you have write access to this fork that is the reason you are able to do it, try doing it with an account that doesn't have write access

@MatthewDeNapoli
Copy link
Collaborator

MatthewDeNapoli commented Apr 19, 2024

Phuong was able to create one and have it merged without having write access so it shouldn't be an issue with the permissions.
#5

@MatthewDeNapoli
Copy link
Collaborator

image
image

@code-Gambler
Copy link
Collaborator Author

Phuong was able to do it, now I am confused, I really don't know what the problem is. This is my secondary account(Doesn't have write access), This is a video of me trying to create a test PR, but I am not able to locate this fork Seneca-CDOT, am I doing wrong? what do you think? same thing was happening with travis

2024-04-18.23-07-35.mp4

@MatthewDeNapoli
Copy link
Collaborator

You need to go to the webpage of your fork and then create the pull request from there.
You're creating the pull request from the main CDOT repository which is why you're not able to select your fork.

Ex.
Go to this link and click the "new pull request" button: https://github.com/nightmareOfDevs/gcc/pulls

@code-Gambler
Copy link
Collaborator Author

Nice, it worked! Damn never did it this for my OSD course!
Thanks, I move this issue to discussion!

@Seneca-CDOT Seneca-CDOT locked and limited conversation to collaborators Apr 19, 2024
@code-Gambler code-Gambler converted this issue into discussion #6 Apr 19, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants