Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ApprovedRevs properties (now part of SemanticApprovedRevs) #111

Open
mwjames opened this issue Mar 2, 2019 · 5 comments
Open

Remove ApprovedRevs properties (now part of SemanticApprovedRevs) #111

mwjames opened this issue Mar 2, 2019 · 5 comments
Milestone

Comments

@mwjames
Copy link
Contributor

mwjames commented Mar 2, 2019

Setup and configuration

  • SESP: 2.x

Issue

@kghbln
Copy link
Member

kghbln commented Mar 3, 2019

Removal should happen before the 2.1 release

Since this is breaking we need to do a 3.0.0 release once SAR 1.0.0 was released.

@kghbln
Copy link
Member

kghbln commented Mar 4, 2019

Once SemanticMediaWiki/SemanticApprovedRevs#3 is done this can be tackled and release with 3.0.0

@kghbln
Copy link
Member

kghbln commented Feb 9, 2020

@mwjames I am not sure how difficult this is. However ideally I would like to release 3.0.0 in February to get this off both our buttocks sooner than later. I guess the bigger pile of work is to get SAR back on track (SemanticMediaWiki/SemanticApprovedRevs#14)

hexmode added a commit that referenced this issue Aug 27, 2020
@alex-mashin
Copy link
Collaborator

Is this task still valid? For some reason, the commit f6ad08e does not seem to be a part of any pull request and has not been merged.

@gesinn-it-gea
Copy link
Member

I see the following issues with moving ApprovedRevs properties to SAR:

  1. SAR does not need the extra properties to do its job. SAR aims to "control the storage of approved revision content", not to provide some semantic annotations about an approval.

  2. Other SESP's have dependencies to other extensions to "lift" their meta data to the semantic world like "_SHORTURL" or "_PAGEIMG". With the same reasoning, separate Semantic Properties extensions would also have to be developed for these extensions. This is especially true because it cannot be assumed that extension developers who have nothing to do with SMW maintain / test code in their extension to provide Extra Properties.

  3. SAR is experimental, so the operation of this extension by administrators may not be acceptable. At the moment, by using SESP and AR, the approval status of a page can be queried through semantic attributes, even if SAR is not used.

I suggest the following:

  • in a first step remove extra special properties from SAR
  • stabilize SAR (status = stable)
  • leave or repair AR properties in SESP
  • if still wanted, ban all SESP "with further dependencies" at a later time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants