Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(refactor): Ruff linter #52

Open
1 task done
psyray opened this issue Apr 22, 2024 · 0 comments
Open
1 task done

feat(refactor): Ruff linter #52

psyray opened this issue Apr 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@psyray
Copy link

psyray commented Apr 22, 2024

Is there an existing feature or issue for this?

  • I have searched the existing issues

Expected feature

Submitted by @jxdv

Currently the styling of the python codebase is inconsistent. Some examples:

  • Mixing up naming conventions (some functions use snake case / camel case etc.)
  • Some files follow the PEP8 spacing between functions / classes / constants etc. and some don't.

Proposed solution:
Writing a GitHub action for Ruff linter. Of course this would take quite a while to refactor the whole codebase, but I can see the project benefitting from it.

Original discussion here
yogeshojha#1134

Alternative solutions

No response

Anything else?

PR has been submitted on legacy repo but not merged in release 2.1.0 yet.
yogeshojha#1145

They need import, review and tests
@AnonymousWP Could you import it ?

@psyray psyray added the enhancement New feature or request label Apr 22, 2024
@yarysp yarysp changed the title feat: Ruff linter feat(refactor): Ruff linter May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant