Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] price_type set before price is set #300

Closed
1 task
G-Huber opened this issue May 13, 2024 · 2 comments · Fixed by #305
Closed
1 task

[BUG] price_type set before price is set #300

G-Huber opened this issue May 13, 2024 · 2 comments · Fixed by #305
Labels
bug Something isn't working

Comments

@G-Huber
Copy link

G-Huber commented May 13, 2024

✔️ Expected Behaviour

Kleinanzeigen resets price_type to fixed when setting price.
So kleinanzeigen-bot would have to make sure to set price before setting price_type

🐞 Actual Behaviour

price_type is set after price causing the Kleinanzeigen webpage to reset the price_type field.

📋 Steps to Reproduce

Possibly configuration dependent?

📺 What browsers are you seeing the problem on? (if applicable)

No response

💻 What operating systems are you seeing the problem on? (if applicable)

No response

📃 Relevant log output (if applicable)

Create ad based on following Template and config.yaml from documentation:

active: # true # true or false
type: # OFFER # one of: OFFER, WANTED
title:
description: ""
# can be multiline, see syntax here https://yaml-multiline.info/

# built-in category name as specified in https://github.com/Second-Hand-Friends/kleinanzeigen-bot/blob/main/kleinanzeigen_bot/resources/categories.yaml
# or custom category name as specified in config.yaml
# or category ID (e.g. 161/27)
category: Notebooks
special_attributes:

price:
price_type: # NEGOTIABLE # one of: FIXED, NEGOTIABLE, GIVE_AWAY

shipping_type: # SHIPPING # one of: PICKUP, SHIPPING, NOT_APPLICABLE
shipping_costs: # e.g. 2.95

# specify shipping options / packages
# it is possible to select multiple packages, but only from one size (S, M, L)!
# possible package types for size S:
# - DHL_2
# - Hermes_Päckchen
# - Hermes_S
# possible package types for size M:
# - DHL_5
# - Hermes_M
# possible package types for size L:
# - DHL_10
# - DHL_31,5
# - Hermes_L
shipping_options: []
sell_directly: # false # true or false, requires shipping_options to take effect

# list of wildcard patterns to select images
# if relative paths are specified, then they are relative to this ad configuration file
images:
  - '*.{JPG,jpg,png}'

id: # set automatically
created_on: # set automatically
updated_on: # set automatically

Code of Conduct

  • I agree to follow this project's Code of Conduct
@G-Huber G-Huber added the bug Something isn't working label May 13, 2024
@G-Huber
Copy link
Author

G-Huber commented May 13, 2024

Seems this has already been addressed in #276

@G-Huber
Copy link
Author

G-Huber commented May 13, 2024

This does not seem to depend on configuration.

I removed price_type from config.yaml and added it to ad.yaml right before price.

Still behaves the same.

provinzio added a commit to provinzio/kleinanzeigen-bot that referenced this issue May 30, 2024
…Friends#300)

selecting the wanted index doesn't trigger a change event which is necessary to update  internal variables regarding the price type

related https://stackoverflow.com/a/60661665
provinzio added a commit to provinzio/kleinanzeigen-bot that referenced this issue May 30, 2024
…Friends#300)

selecting the wanted index doesn't trigger a change event which is necessary to update  internal variables regarding the price type

related https://stackoverflow.com/a/60661665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
1 participant