Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CachingConnector is a poor user experience #61

Open
Bilge opened this issue Nov 6, 2019 · 1 comment
Open

CachingConnector is a poor user experience #61

Bilge opened this issue Nov 6, 2019 · 1 comment

Comments

@Bilge
Copy link
Member

Bilge commented Nov 6, 2019

Having to wrap a connector in CachingConnector just to use caching is not as easy to use as if the cache just worked with any connector. Moreover, cache + connector is a violation of SRP. The cache should be refactored as a separate entity, apart from connectors.

@Bilge
Copy link
Member Author

Bilge commented Nov 8, 2019

There are a couple of problems with removing CachingConnector in lieu of storing the cache within Porter herself:

  1. The same cache would be used for all Porter providers, whereas CachingConnector permits different providers to use different caches very easily; possibly even for different resources, with some ingenuity.
  2. We want to cache the raw connection data, but Porter only receives record collections, which is not what we want to cache and cannot be cached easily (if at all) anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant