Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addon.tab.direction sometimes fails #7374

Closed
WorldLanguages opened this issue Apr 23, 2024 · 0 comments · Fixed by #7386
Closed

addon.tab.direction sometimes fails #7374

WorldLanguages opened this issue Apr 23, 2024 · 0 comments · Fixed by #7386
Labels
scope: addon api Related to the addon.* JS APIs or other ways for addons to provide features type: bug A bug in the addon loader, or in a specific addon

Comments

@WorldLanguages
Copy link
Member

The implementation of the direction getter should use addon.auth.scratchLang instead of relying on scratchAddons.globalState.auth.scratchLang

Related to #6802
@WorldLanguages WorldLanguages added type: bug A bug in the addon loader, or in a specific addon scope: addon api Related to the addon.* JS APIs or other ways for addons to provide features labels Apr 23, 2024
@WorldLanguages WorldLanguages mentioned this issue Apr 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: addon api Related to the addon.* JS APIs or other ways for addons to provide features type: bug A bug in the addon loader, or in a specific addon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix addon.tab.direction bugs and implement __addon global WorldLanguages/ScratchAddons
1 participant
@WorldLanguages