Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make author names in forum quotes clickable #7363

Open
just-a-hriday opened this issue Apr 17, 2024 · 12 comments · May be fixed by #7364
Open

Make author names in forum quotes clickable #7363

just-a-hriday opened this issue Apr 17, 2024 · 12 comments · May be fixed by #7364
Labels
new addon Related to new addons to this extension. `scope: addons` should still be added. scope: addon Related to one or multiple addons type: enhancement New feature for the project

Comments

@just-a-hriday
Copy link
Contributor

just-a-hriday commented Apr 17, 2024

Why this would be helpful

This will make it easier to go to the profile of a user whose post was quoted.

How this addon works

It turns the author names in forum quotes into links:
clickable-quote-authors
Please excuse my choice of example post

It also has an option for hidden links:
clickable-quote-authors_hidden-link

Additional context

I already have this implemented, and I'm ready to create a pull request if this gets accepted.

@just-a-hriday just-a-hriday added new addon Related to new addons to this extension. `scope: addons` should still be added. scope: addon Related to one or multiple addons type: enhancement New feature for the project labels Apr 17, 2024
@Samq64
Copy link
Member

Samq64 commented Apr 17, 2024

This could be part of #4845.

@just-a-hriday
Copy link
Contributor Author

just-a-hriday commented Apr 17, 2024 via email

@Secret-chest
Copy link
Contributor

Putting both in more-links might not be a bad idea though. Both these addons serve the same purpose as more-links - they make things that could be links, but are not links, links.

more-links makes URLs links. Forum mentions makes forum usernames links to make it consistent with comments. This tweaks the site UI, and curator link also tweaks a really specific part of the UI that is completely unrelated. Merging makes no sense.

@Secret-chest
Copy link
Contributor

Also, how we will handle non-user quote names? Like [quote=TOLORS]?

@just-a-hriday
Copy link
Contributor Author

Also, how we will handle non-user quote names? Like [quote=TOLORS]?

The best solution would be to not turn non-usernames into links.
My implementation only allows valid usernames, but I can't think of a way to check if the user actually exists.

@Secret-chest
Copy link
Contributor

Maybe a TOLORS user exists, that's the problem. It would be very unpredictable. How do we know we're quoting TOLORS the post or TOLORS the user?

@mybearworld
Copy link
Contributor

Then the quote is ambiguous anyways. Someone who doesn't know the abbreviation might actually think you're quoting the TOLORS user. This problem wouldn't exist if you'd explicitly say "The Official List Of Rejected Suggestions", which isn't a valid username.

@WorldLanguages
Copy link
Member

Hmm, this is ok, but it's hard to know where it would fit...

@just-a-hriday
Copy link
Contributor Author

Hmm, this is ok, but it's hard to know where it would fit...

I've implemented it as a new addon, but I think it would fit well into more-links.

@just-a-hriday
Copy link
Contributor Author

just-a-hriday commented Apr 18, 2024

I'll just open the pull request if you're fine with the idea, I can put the code into an existing addon later.

@Samq64
Copy link
Member

Samq64 commented Apr 18, 2024

This feels like #4845 all over again where most people agree it's a nice feature to have but no one can agree where to put it.

@Secret-chest
Copy link
Contributor

Let's style it normally so it's unobtrusive for non-users.

@just-a-hriday just-a-hriday linked a pull request Apr 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new addon Related to new addons to this extension. `scope: addons` should still be added. scope: addon Related to one or multiple addons type: enhancement New feature for the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants