Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blue as the accent color in light mode #7358

Open
mxmou opened this issue Apr 14, 2024 · 2 comments
Open

Use blue as the accent color in light mode #7358

mxmou opened this issue Apr 14, 2024 · 2 comments
Labels
scope: accessibility Addresses an accessibility issue scope: design Related to design of the extension scope: webpages Related to the web pages (settings page, pop-up, etc) type: enhancement New feature for the project

Comments

@mxmou
Copy link
Member

mxmou commented Apr 14, 2024

Why this would be helpful

The orange accent color used on the settings page and in the popup doesn't have enough contrast with white.

My suggestion

In #4983, I suggested using orange for selection/focus and blue for emphasis. Because orange on white and blue on dark gray don't have 3:1 contrast, I think it's better to use orange everywhere in dark mode and blue everywhere in light mode.

This issue is about orange elements on white, for example the selected category indicator and enabled addon switches. #7357 is about white on orange.

Possible alternatives

#6027

Additional context

No response

@mxmou mxmou added type: enhancement New feature for the project scope: design Related to design of the extension scope: webpages Related to the web pages (settings page, pop-up, etc) scope: accessibility Addresses an accessibility issue labels Apr 14, 2024
@WorldLanguages
Copy link
Member

The orange accent color used on the settings page and in the popup doesn't have enough contrast with white.

I can only think of the headers, the popup tabs and highlighted buttons. Most other UI elements don't mix orange with white, right? Or am I missing something?

@mxmou
Copy link
Member Author

mxmou commented Apr 14, 2024

The orange accent color used on the settings page and in the popup doesn't have enough contrast with white.

I can only think of the headers, the popup tabs and highlighted buttons. Most other UI elements don't mix orange with white, right? Or am I missing something?

This issue is about orange elements on white, for example the selected category indicator and enabled addon switches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: accessibility Addresses an accessibility issue scope: design Related to design of the extension scope: webpages Related to the web pages (settings page, pop-up, etc) type: enhancement New feature for the project
Projects
None yet
Development

No branches or pull requests

2 participants