Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for "More Links" addons for the messages page #5334

Open
CubesterYT opened this issue Nov 7, 2022 · 5 comments · May be fixed by #7290
Open

Add support for "More Links" addons for the messages page #5334

CubesterYT opened this issue Nov 7, 2022 · 5 comments · May be fixed by #7290
Labels
scope: addon Related to one or multiple addons type: enhancement New feature for the project

Comments

@CubesterYT
Copy link

Why this would be helpful/solve a problem

If you quickly want to access links from a comment or response from someone in the messages page, you should be able to click on the link directly, so you don't have to click on the comment, get redirected to the project page, and THEN click the link.

image

What this change does

Allow clicking links through messages page

Possible alternatives

I don't know

Demonstration(s) and additional context

No need
@CubesterYT CubesterYT added status: needs triage Needs triaging by putting relevant labels type: enhancement New feature for the project labels Nov 7, 2022
@mxmou mxmou added scope: addon Related to one or multiple addons and removed status: needs triage Needs triaging by putting relevant labels labels Nov 8, 2022
@mxmou
Copy link
Member

mxmou commented Nov 8, 2022

Sometimes a part of the link is not visible because the messages page only shows the beginning of the comment. That could be a problem.

@CubesterYT
Copy link
Author

That can't be the problem, the link visible in the comment is not cutoff or broken, it was successfully able to display the full link.

@mxmou
Copy link
Member

mxmou commented Nov 8, 2022

That can't be the problem, the link visible in the comment is not cutoff or broken, it was successfully able to display the full link.

It was not a problem in this case, but it would be if the link was hundreds of characters long. The addon wouldn't know that it's cut off and would make it clickable, but clicking it would probably show an error. That could be confusing.

@WorldLanguages
Copy link
Member

Sometimes a part of the link is not visible because the messages page only shows the beginning of the comment. That could be a problem.

I was going to say that too.

I guess we could avoid link-ifying the last word of the comment, because we can't be sure if the link would be complete (by "last word" I mean comment.split(" ").at(-1))

@mxmou
Copy link
Member

mxmou commented Nov 27, 2022

I guess we could avoid link-ifying the last word of the comment, because we can't be sure if the link would be complete (by "last word" I mean comment.split(" ").at(-1))

Links usually appear at the end of a comment so that would break most of them. Maybe the addon could check if the length of the comment text is 250 - if it is, it might be truncated.

@mxmou mxmou linked a pull request Mar 23, 2024 that will close this issue
Open
@mybearworld mybearworld mentioned this issue Mar 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: addon Related to one or multiple addons type: enhancement New feature for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow links to be clickable in the messages page Jazza-231/ScratchAddons
3 participants
@WorldLanguages @mxmou @CubesterYT