Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #53: Added Prettier support #54

Closed
wants to merge 1 commit into from
Closed

Fix #53: Added Prettier support #54

wants to merge 1 commit into from

Conversation

ducksblock
Copy link

@ducksblock ducksblock commented Jul 28, 2023 •
edited

Description

  • Added .prettierrc and .prettierignore
  • Let me know if you want me to run the prettier write command to update the style of all the files

Closes #53

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@GhostOf0days
Copy link
Member

Hi @ducksblock. I appreciate the PR. However, unfortunately, I'm going to close this PR as we are using bootcamp tasks as recruitment for ScottyLabs for the new CMU freshman and any other class years interested in joining.

GhostOf0days
GhostOf0days reviewed Jul 30, 2023
View reviewed changes
Copy link
Member

@GhostOf0days GhostOf0days left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the PR. Unfortunately, I will not merge it as we are using bootcamp tasks for ScottyLabs recruitment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GhostOf0days GhostOf0days GhostOf0days left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Prettier Support
2 participants
@ducksblock @GhostOf0days