Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for All Edge Cases #150

Open
GhostOf0days opened this issue May 11, 2024 · 0 comments
Open

Account for All Edge Cases #150

GhostOf0days opened this issue May 11, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@GhostOf0days
Copy link
Member

GhostOf0days commented May 11, 2024

We have run into multiple failures on CMUEats because the Dining API doesn't account for all edge cases. I have provided a detailed outline of edge cases to account for in https://github.com/ScottyLabs/dining-api/wiki/Timing-Cases.

To account for these, we need to fix the timing logic in https://github.com/ScottyLabs/dining-api/blob/main/src/parser/diningParser.ts, starting at the following line:

const timeBuilder = new TimeBuilder();

@GhostOf0days GhostOf0days added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant