Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Archive Unavailable Items #188

Merged
merged 9 commits into from
Dec 18, 2022
Merged

Bulk Archive Unavailable Items #188

merged 9 commits into from
Dec 18, 2022

Conversation

michellejli77
Copy link
Contributor

@michellejli77 michellejli77 commented Nov 19, 2022

Description

This PR allows admins to bulk archive all unavailable items older than a specified number of days. Specifically, the archiveByDays API function is altered to allow filtering on availability. This allows admins to easily archive unavailable items, which reduces the number of active items on the front page of the website.

Closes #178

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Add items with different availabilities
  • Check that the bulk archive button only archives unavailable items
  • Check that string inputs and negative numbers for the days prompt an error

Test Configuration:

  • Node.js version: 14.18.0
  • Desktop/Mobile: Desktop
  • Browser: Chrome

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@elouiestudent elouiestudent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elouiestudent elouiestudent merged commit 469eb1c into main Dec 18, 2022
elouiestudent added a commit that referenced this pull request Dec 19, 2022
@michellejli77 michellejli77 deleted the mli6/bulk-archive branch April 13, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Bulk archive button for unavailable items
2 participants