[Bug] The archive entry was compressed using an unsupported compression method

[aetonsi]

Bug Report

Current Behavior

If some package downloads a zip file compressed using some "peculiar" compression methods, scoop can't unpack them if running in Windows Powershell, and the installation breaks.
I don't think this is related to a single package, but i'm not sure as i don't know how the general installation process works in scoop.

You can try with nano. Open up a brand new Windows Sandbrox and in powershell just install scoop then immediately install nano (see full output below).

If you check the downloaded file ( https://github.com/rivy/scoop.bucket.scoop-main/blob/0c61592bb82a5af8ea17b88341d72cc09160285f/nano.json#LL9C21-L9C128 ) it's using Deflate64 for most of its files, internally.
I opened the issue here because i noticed that, if a package, any package, also installs 7zip, then every subsequent installation will not fail like this; so i'm guessing that it's scoop the one choosing to use [System.IO.Compression.ZipFileExtensions]::ExtractToFile (that apparently doesn't support Deflate64, in its older .NET Framework 4.8.x version -which should be the one used by windows powershell-) or 7zip, if installed (that supports anything). Also see the output below, i installed curl which downloads 7zip, then reinstalled nano with no problems.

If the de-compression part is up to every package, then please close this issue, and sorry for bothering.

Expected Behavior

Just for the decompression to work.

Additional context/output

Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

Install the latest PowerShell for new features and improvements! https://aka.ms/PSWindows

PS C:\Users\WDAGUtilityAccount> $PSVersionTable                                                                                                                                                                                                                                                                                             Name                           Value                                                                                                                                  ----                           -----                                                                                                                                  PSVersion                      5.1.22621.963                                                                                                                          PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22621.963
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1



PS C:\Users\WDAGUtilityAccount>
>> Set-ExecutionPolicy RemoteSigned -Scope CurrentUser -confirm:$false -force
>> irm get.scoop.sh | iex
>>
Initializing...
Downloading ...
Extracting...
Creating shim...
Adding ~\scoop\shims to your path.
Scoop was installed successfully!
Type 'scoop help' for instructions.
PS C:\Users\WDAGUtilityAccount> scoop install nano
Installing 'nano' (7.2-22.1) [64bit] from main bucket
nano-for-windows_win64_v7.2-22.1.zip (279.0 KB) [===========================================================================================================] 100%
Checking hash of nano-for-windows_win64_v7.2-22.1.zip ... ok.
Extracting nano-for-windows_win64_v7.2-22.1.zip ... Exception calling "ExtractToFile" with "3" argument(s): "The archive entry was compressed using an unsupported compression method."
At C:\Windows\system32\WindowsPowerShell\v1.0\Modules\Microsoft.PowerShell.Archive\Microsoft.PowerShell.Archive.psm1:1056 char:25
+ ...             [System.IO.Compression.ZipFileExtensions]::ExtractToFile( ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : InvalidDataException

done.
Running pre_install script...
Linking ~\scoop\apps\nano\current => ~\scoop\apps\nano\7.2-22.1
Creating shim for 'nano'.
Can't shim 'nano.exe': File doesn't exist.



PS C:\Users\WDAGUtilityAccount> # now i install CURL which also downloads 7zip
PS C:\Users\WDAGUtilityAccount> scoop install curl
Installing '7zip' (22.01) [64bit] from main bucket
7z2201-x64.msi (1.8 MB) [===================================================================================================================================] 100%
Checking hash of 7z2201-x64.msi ... ok.
Extracting 7z2201-x64.msi ... done.
Linking ~\scoop\apps\7zip\current => ~\scoop\apps\7zip\22.01
Creating shim for '7z'.
Creating shim for '7zFM'.
Creating shim for '7zG'.
Creating shortcut for 7-Zip (7zFM.exe)
Persisting Codecs
Persisting Formats
Running post_install script...
'7zip' (22.01) was installed successfully!
Notes
-----
Add 7-Zip as a context menu option by running: "C:\Users\WDAGUtilityAccount\scoop\apps\7zip\current\install-context.reg"
Installing 'curl' (8.0.1_9) [64bit] from main bucket
curl-8.0.1_9-win64-mingw.tar.xz (6.2 MB) [==================================================================================================================] 100%
Checking hash of curl-8.0.1_9-win64-mingw.tar.xz ... ok.
Extracting curl-8.0.1_9-win64-mingw.tar.xz ... done.
Linking ~\scoop\apps\curl\current => ~\scoop\apps\curl\8.0.1_9
Creating shim for 'curl'.
'curl' (8.0.1_9) was installed successfully!



PS C:\Users\WDAGUtilityAccount> # now i install nano again
PS C:\Users\WDAGUtilityAccount> scoop install nano
WARN  Purging previous failed installation of nano.
ERROR 'nano' isn't installed correctly.
Removing older version (7.2-22.1).
'nano' was uninstalled.
Installing 'nano' (7.2-22.1) [64bit] from main bucket
Loading nano-for-windows_win64_v7.2-22.1.zip from cache
Checking hash of nano-for-windows_win64_v7.2-22.1.zip ... ok.
Extracting nano-for-windows_win64_v7.2-22.1.zip ... done.
Running pre_install script...
Linking ~\scoop\apps\nano\current => ~\scoop\apps\nano\7.2-22.1
Creating shim for 'nano'.
'nano' (7.2-22.1) was installed successfully!
Notes
-----
The old config file has been backed up to "C:\Users\WDAGUtilityAccount\scoop\apps\nano\current\.nanorc.bak"

Possible Solution

Always download 7zip if running in WinPosh?

System details

Windows version: win 11 (Microsoft Windows [Version 10.0.22621.1702])

OS architecture: x64

PowerShell version: 5.1.22621.963

Additional software: nothing at all. fresh install of scoop on a "clean" OS (sandbox or not)

Scoop Configuration

{
"last_update":  "2023-05-14T18:56:49.9462965+02:00"
}

[hamderdoygaard]

@aetonsi - It worked like a charm!

Thanx bro, lifesaver.

[rashil2000]

Hmm, I see, thanks for the detailed investigation.

I guess the reason we don't see this issue often is because 7zip (an internal dependency) almost always gets installed once you start using Scoop (for archives that are not zips, which is very very likely).

[aetonsi]

mmh would it maybe be better to install it anyway? since it's needed for zips, also, if they have an unusual compression algo....