-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues performing .get() to CTA_FILE_URL from behind internal firewall #303
Comments
Hi and thanks for your input. I will look into the possbility of using JSON - if the SBTi has this possbility. A fallback will be introduced so that we check for a status code of 200, and if this fails we'll fetch the file included in the package instead. It might not be the very latest but I think it will be possible to manually load the file to that directory if the user can access it in some other way than through the tool. |
edited - hit send too soon! thanks JSON response would definitely be simpler for us to perform the shall I knock up a PR to add the targets.xlsx file to the GH repo and read from local if the request.get fails? I would just put the current file into https://github.com/ScienceBasedTargets/SBTi-finance-tool/tree/main/SBTi/data?
suggestions for where could get user to load the file to? as for |
Well here's some good news. There will soon be a new api with the CTA delivered in JSON format. I don't have a date yet, but the code to update the tool is being prepared. |
thats great thanks - shall we leave this issue open until the API and check if status == 200 PR has been opened so can link the PR and issue?
We should be able to just use the |
Yes, let's leave it open until the API is ready. But I will add the status == 200 and perhaps leave an option to read the CTA file from the directory "data" that is created when running the tool in Colab. (If you run it in your own Jupyter environment you should be able to see the CTA file anyway.) |
Our model currently uses v1.0.5 and we are struggling to update to v1.0.6+ because the requests.get() introduced in 2c9ca5d to get the CTA_FILE_URL from behind internal firewall fails. We can go through a semi-lengthy exemption process but below changes will make it simpler and generally safer.
this issue to discuss some possible changes
The text was updated successfully, but these errors were encountered: