Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITP default values differ from Tuning Parameters #108

Open
judober opened this issue Dec 15, 2023 · 2 comments
Open

ITP default values differ from Tuning Parameters #108

judober opened this issue Dec 15, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@judober
Copy link

judober commented Dec 15, 2023

First of all, thank you for this great package!

When looking through the documentation of the ITP-Method (and the code), I noticed that the default values of the parameters are different between the header (==code) and the 'Tuning Parameters' section which seems to be wrong.
Is there a reason that k2 is not an int as recommended in the text?

@judober judober added the bug Something isn't working label Dec 15, 2023
@ChrisRackauckas
Copy link
Member

I think the docstrings and such just didn't get updated. On the int thing, maybe @DaniGlez can chime in

@DaniGlez
Copy link
Contributor

This did indeed pop up in the discussion we had with Oscar, I think we just did not act on this specific point (probably because I was not sure if the default values were coming from some analysis I was not aware of): SciML/DiffEqBase.jl#917 (comment)

But it seems indeed sensible to set it to 2, and we can port that to the InternalITP from DiffEqBase as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants