Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the query to search songs with YouTube #374

Open
tposejank opened this issue Feb 24, 2024 · 3 comments · May be fixed by #375
Open

Change the query to search songs with YouTube #374

tposejank opened this issue Feb 24, 2024 · 3 comments · May be fixed by #375

Comments

@tposejank
Copy link

Is your feature request related to a problem? Please describe.
Problem is very common: not downloading correct tracks.
My proposed solution is below:
Change the query the youtube.py file does so that:

  • Lyric channels with intro music/long intros
  • Lyric channels with outros/song fading
  • Lyric channels that use official music videos
  • Artists with more popular music that their other songs don't get recommended first and instead their most popular release (Ej: indie artists)
  • Nightcore remixes that take over the search results
  • Music with no lyrics being searched as lyric videos
  • Low quality exported lyric videos
    ...these cases don't occur when music is searched

Describe the solution you'd like
Instead of query being: "Artist - Song Lyrics"
It can be: "Artist - Song Official Audio", preferably if the Song goes before the artist: "Song - Artist Official Audio".
So that YouTube can give as results the artist's official audio (usually the square image or a video with just the audio)

Additional context
As an example: Frizk, who made a popular TikTok audio, searching for any of his other songs may result to getting the popular audio as a first result, also being that he does not have many sung releases.

If it is unclear what I am mentioning: here

@Maritsu
Copy link

Maritsu commented Mar 11, 2024

I'm having issues with this too; so far I've come up with maybe dropping the 'Lyrics' search tag, making use of Sponsorblock and additionally searching on YT Music instead?

@tposejank
Copy link
Author

I'm having issues with this too; so far I've come up with maybe dropping the 'Lyrics' search tag, making use of Sponsorblock and additionally searching on YT Music instead?

I also thought about YT Music for this issue, but I scrapped the idea since the YT library may not support it.

@Maritsu
Copy link

Maritsu commented Mar 16, 2024

It seems like the built-in search function of yt-dlp doesn't support YT Music, but there's a library called ytmusicapi that could be used to get the song's URL (as seen in this SO thread). i'll try forking the project and implementing this

Maritsu added a commit to Maritsu/spotify-dl that referenced this issue May 25, 2024
…at#374)

- add ytmusicapi as dependency
- modify dump_json() and find_and_download_songs() to use YT Music
@Maritsu Maritsu linked a pull request May 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants