Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing parameter type #110

Open
Cleecanth opened this issue Sep 9, 2019 · 0 comments
Open

Handle missing parameter type #110

Cleecanth opened this issue Sep 9, 2019 · 0 comments

Comments

@Cleecanth
Copy link

With the new nunjucks templates, the @parameter type no longer handles undefined values. Before this change, an undefined type just showed up as a blank string.

At the moment, parameter.type is passed to the display_as_type filter — where it tries to split it even if it's undefined.

I'm not sure if type is required or not on parameters, but in either case the absence of a type causes a pretty hard-to-track-down nunjucks render error.

I'm more than willing to put in a PR to fix this, but I don't want to assume behavior. If type is required for parameters, maybe this should be handled on the parser side of things. If it's not, then protecting the parameter.type logic is probably sufficient (in the same way that the @type template is protected).

Thanks for all your work. Let me know if you'd like me to add a PR.

Cleecanth added a commit to UWHealth/sass-tools that referenced this issue Sep 9, 2019
Gulp task patches bug in sassdoc theme.
See sassdoc-theme-default issue:
SassDoc/sassdoc-theme-default#110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant