Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in the subtitles synchronization after pressing the skip intro button #446

Closed
2 of 4 tasks
Essam311 opened this issue Apr 11, 2020 · 15 comments
Closed
2 of 4 tasks
Labels

Comments

@Essam311
Copy link

Essam311 commented Apr 11, 2020

Addon used

  • Amazon VOD (plugin.video.amazon-test)
  • Browser Launcher (plugin.program.browser.launcher)
  • Addon Version: 0.8.3

Prime Video Account (select one)

  • primevideo.com
  • amazon.(com/co.uk/de/jp)

System Setup (please provide the following information):

  • Hardware: PC
  • OS Version: Windows 10
  • Kodi Version: Kodi 19 Matrix

Upload Logs
Upload kodi.log somewhere and post the link here. If you need help finding it, read the appropriate entry in the FAQs.
For Login issues, enable advanced logging in the settings, upload the (amazon/avod)-login files from the Kodi Home folder, and paste the link here, as well.

Describe the bug
A clear and concise description of what the bug is.

The subtitles become not synchronized after pressing the skip intro button.

@Sandmann79
Copy link
Owner

Sandmann79 commented Apr 11, 2020

Maybe a Kodi player related bug. It's a strange behaviour - by seeking to a specific time the subtitles won't synchronised, but by skipping with arrow keys everything is synchronised.

Edit: okay by using jsonrpc player.seek it works perfectly. Changing this soon.

@Varstahl Varstahl added the bug label Apr 11, 2020
Sandmann79 added a commit that referenced this issue Apr 11, 2020
@Essam311
Copy link
Author

Thank you so much, c2a35f8 fixed the problem for me.

@Essam311
Copy link
Author

@Sandmann79 590183e made the subtitles become not synchronized again after pressing the skip intro button, tested with the TV series "The office" season three episode 5.

@Sandmann79
Copy link
Owner

Yep forget to test this yesterday. 24edde0 should fix this.
It's not my favourite solution for this bug, but maybe the only one.

@Essam311
Copy link
Author

@Sandmann79 Thank you, 24edde0 works fine.

@Essam311
Copy link
Author

Essam311 commented Apr 12, 2020

@Sandmann79 Skip Recap does not work correctly with 24edde0 it works correctly with c2a35f8 tested with the TV series "The Office" season 3 episode 11 and the TV series "American Gods" season 2 episode 1.

@Sandmann79 Sandmann79 reopened this Apr 13, 2020
@Sandmann79
Copy link
Owner

@Essam311 You mean The Office (US) 3x11 - Back from vacation? If yes, this shouldn't work with the patch you mentioned.

But never mind there is something new to test for you. This time as attachment (i won't spam the commits with this trial & error testing). Just unzip this file to plugin.video.amazon-test\resources\lib.
playback.zip

@Essam311
Copy link
Author

Essam311 commented Apr 13, 2020

@Sandmann79 Thank you, skipping intro and recap working great now and the subtitles are synchronized after using https://github.com/Sandmann79/xbmc/files/4470141/playback.zip. If possible please add an option for auto skipping intro and recap to the settings.

@Varstahl
Copy link
Collaborator

That might be useful as a sub-option for skip buttons enabling setting. Also, slight off topic, @Sandmann79 when selecting Script playback method the browser field is visible. It shouldn't right? Might have messed that at some point.

@Sandmann79
Copy link
Owner

Sandmann79 commented Apr 13, 2020

@Essam311 that should be possible
@Varstahl or as list setting "intro/recap scenes processing" with options do nothing, display button, autoskip intro, autoskip recap, autoskip all?
The browser field is just for using the correct fullscreen command.

@Essam311
Copy link
Author

Essam311 commented Apr 13, 2020

@Sandmann79 The file https://github.com/Sandmann79/xbmc/files/4470141/playback.zip seems not to work all the time correctly, after pressing the Skip Intro button it skips too much more time forward.

@Sandmann79
Copy link
Owner

You're talking from seconds or minutes? Can you provide a debug log?

@Essam311
Copy link
Author

Essam311 commented Apr 13, 2020

@Sandmann79 It skipped forward about two minutes more, here is the debug log, tested with episode 20 in season 3 from The office (US) in primevideo.com "Safety Training" (the episodes in primevideo.com for season 3 from the office (US) have different numbers than the ones in amazon.com after episode 9)

https://pastebin.com/JjxdA0Si

https://www.primevideo.com/detail/The-Office/0IQYBG19L3RUTFGEFLTEVIACSX

https://www.amazon.com/The-Office-Season-3/dp/B000U5OF1U

@Sandmann79
Copy link
Owner

Okay somewhere between your Kodi build (20200408) and my version (20200324) they fixed that issue with seeking from play position. That's the reason why commit c2a35f8 works perfectly for you.
On older versions seeking forward with values lower 60 seconds will result in jumping direct to this position from the beginning instead current position of video.

@Essam311
Copy link
Author

@Sandmann79 Thank you so much for adding the option for automatically skipping intro and recap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants