Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send all sound off message at end of loop #307

Open
SanderVocke opened this issue Mar 15, 2024 · 0 comments
Open

Don't send all sound off message at end of loop #307

SanderVocke opened this issue Mar 15, 2024 · 0 comments
Labels
feature New features or feature improvements

Comments

@SanderVocke
Copy link
Owner

This is overkill, and also we are only doing it on channel 0:

MidiChannel<TimeType, SizeType>::PROC_send_all_sound_off(unsigned frame) {
    auto &buf = mp_playback_target_buffer.value();
    if (buf.first.frames_left() < 1) {
        throw_error<std::runtime_error>(
            "Attempting to play back out of bounds");
    }
    PROC_send_message_value(*buf.second,
        frame, 3, uint8_t {0xB0, 120, 0})
}

Rather, just send whatever we need to send to deactivate active notes.

@SanderVocke SanderVocke added bug Something isn't working feature New features or feature improvements and removed bug Something isn't working labels Mar 15, 2024
@SanderVocke SanderVocke modified the milestone: Initial release Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or feature improvements
Projects
None yet
Development

No branches or pull requests

1 participant