Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bchardev freezes on close on OTA partiton #1690

Open
pholat opened this issue May 10, 2018 · 7 comments
Open

bchardev freezes on close on OTA partiton #1690

pholat opened this issue May 10, 2018 · 7 comments
Assignees

Comments

@pholat
Copy link

pholat commented May 10, 2018

I need OTA functionality for our application and added some (dirty WIP) code for just that, as well as updated example in apps/examples directory here:
https://github.com/pholat/TizenRT/tree/ota_tests

I've just one issue in line:
os/drivers/fota/fota_driver.c:192 close(fota_fd);
This close closes bchrdev created on fota partition driver, though for some reason in hangs.

When I restart the board ota partion is being read and app is being updated. I'm quite convinced that it shouldn't be hanging itself on close I'll be very glad to any pointers how it could be possibly fixed, so I could clean it up and make PR with OTA working fine.

@sunghan-chang
Copy link
Contributor

@jeongchanKim Please check this.

@jeongchanKim
Copy link
Contributor

I checked your code(https://github.com/pholat/TizenRT/tree/ota_tests), but that is not from our repo.
I'm sorry but we cannot cover not from ours.

@pholat
Copy link
Author

pholat commented May 16, 2018

@jeongchanKim I don't understand what you need not from your repo? It's forked form TizenRT here. II've just added lacking driver as I need it, though have some issue with bchdev which can't seem to get closed.
Or do you mean it's part of legit Nuttx code TizenRT developers do not maintain?

@jeongchanKim
Copy link
Contributor

In our code, there is no issue for fota without bchdev. So I don't know why you added the bch.

@pholat
Copy link
Author

pholat commented May 21, 2018

@jeongchanKim there was no fota driver at all, that's why I've used bchdev to write the update onto the flash. There was no issue, because there was no fota driver at all. If it was there - I would have never tried to do it myself.

@jeongchanKim
Copy link
Contributor

Okay I understand what you're saying.
But, which board do you use?
If you use artik, fota driver is not required for current version. Because artik05x_configure_partitions automatically set the driver.
If you don't use artik, you are right, we should check fota driver code.

@pholat
Copy link
Author

pholat commented Jul 24, 2018

@jeongchanKim
Sorry for late response - I missed the reply :)
I use Artik053s - I needed something to write OTA given binary to OTA partition, so I've added simple code using bchdev to write the data onto this partition. Then when I call flush on bchdev on the mentioned partition at the end of writes it just hangs.

I hope I was 100% clear now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants