Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[one-import-onnx] Provide option to switch using extension #12872

Open
seanshpark opened this issue Apr 16, 2024 · 2 comments
Open

[one-import-onnx] Provide option to switch using extension #12872

seanshpark opened this issue Apr 16, 2024 · 2 comments

Comments

@seanshpark
Copy link
Contributor

Current implementation of one-import-onnx invokes one-import-onnx-ext if it exist.
Not to use the extension is to uninstall that package.
This is simple but not friendly for users for switch using onnx-tf or new extension.

Let's provide an option in one-import-onnx section.

@seanshpark
Copy link
Contributor Author

seanshpark commented Apr 16, 2024

Our choice of usage

case 1) switch to use legacy

  • provide a switch to use legacy onnx-tf if given
  • this provides same user experience with extension
  • and can turn it off with something like use_onnx_tf=True

case 2) switch to use extension

  • provide a switch to use new one-import-onnx-ext extension
  • this provides same user experience with existing onnx-tf independent on extension installation
  • but breaks user experience with current extension installation

@SlavikMIPT SlavikMIPT assigned SlavikMIPT and unassigned SlavikMIPT Apr 16, 2024
@jinevening
Copy link
Contributor

I think that one-import-onnx-ext should be a default onnx importer of our toolchain. So, +1 for the case 1. (adding use_onnx_tf option).

And, I think it would better to print a warning message whenever onnx-tf is used, e.g., "onnx-tf will be deprecated soon. Please install onnx2circle.".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants