Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 7 support #222

Open
bbashel1 opened this issue May 14, 2020 · 7 comments
Open

Laravel 7 support #222

bbashel1 opened this issue May 14, 2020 · 7 comments

Comments

@bbashel1
Copy link

I added laravel 7 support in this fork if anyone wants to use.
https://github.com/bbashel1/LaravelFacebookSdk

@Fuhrmann
Copy link

Fuhrmann commented Jul 1, 2020

I do not see any changes to the code in your forked version of the package, what exactly did you changed?

Here, it`s in another branch: https://github.com/bbashel1/LaravelFacebookSdk/tree/laravel-7-support

@MarcoTroost
Copy link

Awesome, thank you for the fork.
How do I point to this specific fork from my composer.json?

Thus far I have:

"repositories": [
{
"type": "vcs",
"url": "https://github.com/s1rc/LaravelFacebookSdk"
}
],
"require": {
"sammyk/laravel-facebook-sdk": "dev-s1rc:30"
},

But that doesn't work. Any ideas?

@smartssa
Copy link

smartssa commented Sep 4, 2020

@MarcoTroost you need to add the 'name' to override the origin in your repository block.

  {
    "type": "vcs",
    "name":"sammyk/laravel-facebook-sdk",
    "url": "https://github.com/s1rc/LaravelFacebookSdk"
  }],
  "require": {
    "sammyk/laravel-facebook-sdk": "dev-s1rc:30"
  }

Otherwise, it will look at the origin for sammyk's package.

@theamanjs
Copy link

@smartssa if I'll use this will there be any change in code or will anything break after this?

@smartssa
Copy link

smartssa commented Nov 9, 2020

I cannot confirm changes to code in this branch (it's not mine) - you can check the history. I forked my own from sammyk and only changed the dependency. No other code changes were needed for my own personal usage.

@geoff-maddock
Copy link

Anyone looking to update this to Laravel 8? I use it in my package and was looking at updating.

@devinyasas
Copy link

I updated my project to Laravel 8. And when upgrading, I didn't get any errors. It's strange and I It's working. Is this normal? Can someone explain me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants