Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buggy Tests #482

Closed
Gerhardsa0 opened this issue Oct 24, 2023 · 5 comments · Fixed by #495
Closed

Buggy Tests #482

Gerhardsa0 opened this issue Oct 24, 2023 · 5 comments · Fixed by #495
Labels
bug 🪲 Something isn't working released Included in a release testing 🧪 Additional automated tests

Comments

@Gerhardsa0
Copy link
Contributor

Describe the bug

The test: test_should_match_snapshot sometimes runs through and sometimes doesnt. After running the tests a few times, there seems to be no more trouble and just gives warning.

To Reproduce

  1. clone main repo
  2. run tests

Expected behavior

Expect the test to run through

Screenshots (optional)

No response

Additional Context (optional)

No response
@Gerhardsa0 Gerhardsa0 added bug 🪲 Something isn't working testing 🧪 Additional automated tests labels Oct 24, 2023
@lars-reimann lars-reimann changed the title Bugy Tests Buggy Tests Oct 24, 2023
@lars-reimann
Copy link
Member

lars-reimann commented Oct 24, 2023 •
edited

Which test fails specifically? There are multiple tests with that name.

@Gerhardsa0
Copy link
Contributor Author

Which test fails specifically? There are multiple tests with that name.

this test fails: tests/safeds/data/tabular/containers/_table/test_plot_correlation_heatmap.py

could be something with my setup, I get this Error: This probably means that Tcl wasn't installed properly.

@lars-reimann lars-reimann added wontfix This will not be worked on third party We need to wait for someone else labels Oct 28, 2023
@lars-reimann
Copy link
Member

It could be related to pypa/virtualenv#93. I've also encountered this when running the tests from the command line sometimes (but never when running the tests using a run configuration in PyCharm). Since the linked issue is now more than 12 years old, I wouldn't get my hopes up that this gets fixed anytime soon. I'm closing this, since there's nothing we can do to fix this besides not using poetry anymore.

@lars-reimann lars-reimann closed this as not planned Won't fix, can't repro, duplicate, stale Oct 28, 2023
@lars-reimann lars-reimann removed wontfix This will not be worked on third party We need to wait for someone else labels Nov 16, 2023
@lars-reimann lars-reimann reopened this Nov 16, 2023
@lars-reimann
Copy link
Member

I may have a fix for this.

@lars-reimann lars-reimann mentioned this issue Nov 16, 2023
Merged
lars-reimann added a commit that referenced this issue Nov 22, 2023
@lars-reimann @megalinter-bot
test: snapshot tests (#495)
6deddbe 
Closes #482
Closes #483

### Summary of Changes

* Use [sypury](https://github.com/tophat/syrupy) snapshot tests for
images. Run `pytest --snapshot-update` to update snapshots after
changes.
* Fix random test failures due to TCL when running tests in a terminal

---------

Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com>
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🪲 Something isn't working released Included in a release testing 🧪 Additional automated tests
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: snapshot tests Safe-DS/Library
2 participants
@lars-reimann @Gerhardsa0