Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scoreLead display on graph #755

Open
3 tasks
tibboh opened this issue Nov 23, 2020 · 6 comments · May be fixed by #828
Open
3 tasks

scoreLead display on graph #755

tibboh opened this issue Nov 23, 2020 · 6 comments · May be fixed by #828

Comments

@tibboh
Copy link

tibboh commented Nov 23, 2020

Even when the scoreLead display is chosen, the right-hand side graph displays winrate only. I propose changing it so that scoreLead is displayed instead (or in addition).

I have a working solution, which I'd like to polish and send a PR, if you like the idea. I imagine the following steps:

  • Adding an extra property to each move (SBKV is used for winrate, we could add SBKS?)
  • Passing both winrate and scoreLead data to the winrate graph
  • Adding some Y-axis labels (say 50% and 100% for winrate, and auto-computed values for scoreLead). Should we display both values on the graph (using left/right Y-axis scale), or just the one currently shown on the board? I'm leaning towards displaying just one - it's cleaner and more coherent.
@geovens
Copy link
Contributor

geovens commented Dec 21, 2020

I like this feature and hope it could get merged.

@apetresc
Copy link
Member

apetresc commented Apr 6, 2021

If you have a working solution, please submit it! I think we'd be definitely interested in merging a good implementation of this.

@tibboh
Copy link
Author

tibboh commented Apr 6, 2021

Thanks! I'll clean up my implementation and send PRs in the order described above.

@kevinsung
Copy link

@tibboh are you still planning to submit PRs for this issue? I found some issues with @zogwarg's #823 and am interested to see your implementation. In particular, I think you got the last point correct in your opening post, which is that the graph should only display one of the values (win rate or score lead) at a time.

@tibboh
Copy link
Author

tibboh commented Oct 6, 2021

Hi, I didn't have time to clean up my code and probably won't be able to do this for the next month or so. I do think the graph should show the same metric that's shown on the board.

@kevinsung
Copy link

Making the graph value type match the heatmap would require some design decisions regarding the "View" menu layout and keyboard shortcuts. I think it's reasonable to do it this way:

  • "Show Heatmap" and "Show Analysis Graph" are simple menu items instead of submenus
  • There is a new submenu called "Analysis Metric" or something like that with items "Winrate" and "Score Lead"
  • Retain the keyboard shortcut Ctrl-Shift-H, which now toggles the "Analysis Metric" submenu instead of the "Show Heatmap" submenu

@kevinsung kevinsung linked a pull request Oct 11, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants