Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVF_INSTALL_INCLUDE_DIR lacks svf suffix #1411

Open
251 opened this issue Mar 15, 2024 · 1 comment
Open

SVF_INSTALL_INCLUDE_DIR lacks svf suffix #1411

251 opened this issue Mar 15, 2024 · 1 comment

Comments

@251
Copy link
Contributor

251 commented Mar 15, 2024

Hi,

make install copies all include directories to prefix/include without a svf parent directory which is quite non-standard behaviour:

set(SVF_INSTALL_INCLUDE_DIR ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_INCLUDEDIR})

This seems to work for me:

CMakeLists.txt:

-set(SVF_INSTALL_INCLUDE_DIR ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_INCLUDEDIR})
+set(SVF_INSTALL_INCLUDE_DIR ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_INCLUDEDIR}/svf)
 
-file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/include)
+file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/include/svf)

-configure_file(${SVF_SOURCE_DIR}/.config.in ${SVF_BINARY_DIR}/include/Util/config.h)
+configure_file(${SVF_SOURCE_DIR}/.config.in ${SVF_BINARY_DIR}/include/svf/Util/config.h)
 
-  FILES ${SVF_BINARY_DIR}/include/Util/config.h
-  DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/Util
+  FILES ${SVF_BINARY_DIR}/include/svf/Util/config.h
+  DESTINATION ${SVF_INSTALL_INCLUDE_DIR}/Util

ExtAPI.h:

-#include <Util/config.h>
+#include <svf/Util/config.h>

ExtAPI.cpp

-#include "Util/config.h"
@yuleisui
Copy link
Collaborator

@bjjwwang would this affect SVF’s npm or anything else? If not, we could make this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants