Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a slight discrepancy between the content of the paper and the code. #5

Closed
githubdemima123456 opened this issue Apr 24, 2024 · 3 comments

Comments

@githubdemima123456
Copy link

In Section 3.2, "Problem Setup and Notation," the variable Y is determined by the random variable Z1 and others, but in the corresponding code, the variable Y is determined by the random variable Z2 and others, and theoretically, it is also determined by Z2.

@kimmo1019
Copy link
Member

Thanks for your feedback, you are right. (Z1, Z2) in the paper corresponds to (Z2, Z1) in the code. Will fix it in the next update

@kimmo1019
Copy link
Member

kimmo1019 commented Apr 24, 2024

For all users, we currently have no theoretical guidance for the choice of dim(Zi) so far without prior knowledge. In most of the experiments in our CausalEGM paper, Z1 Z2 have the same dimension. Our current new work is trying to mitigate this problem by providing more theoretical analysis.

@kimmo1019
Copy link
Member

@githubdemima123456 Hi, please find the latest release v0.4.0, which solves the discrepancy between paper and code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants