Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples that pass args to renderRouteHandler are out of date #184

Open
wbobeirne opened this issue Nov 1, 2016 · 0 comments
Open

Examples that pass args to renderRouteHandler are out of date #184

wbobeirne opened this issue Nov 1, 2016 · 0 comments

Comments

@wbobeirne
Copy link

The following commit removed the props args from renderRouteHandler: e6806f6

However, you can see that it's still used in examples here, here and here. These examples no longer work, which left me scratching my head for AnimatedLocations.jsx for a little while. I was able to replace that with:

const handler = React.cloneElement(this.renderRouteHandler(), {
	key: this.state.match.path,
});

return (
	<CSSTransitionGroup { ...this.props } { ...props }>
		{handler}
	</CSSTransitionGroup>
);

The examples here, and possible in https://github.com/STRML/react-router-component-transition should be updated to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant