Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of STIXCIQIdentity3_0 and its children entities does not emit the "Entity.created.from_obj" signal #356

Open
stevefranchak opened this issue Oct 4, 2018 · 3 comments

Comments

@stevefranchak
Copy link

It appears that the from_obj method of the STIXCIQIdentity3_0 class and classes for child nodes of stix-ciqidentity:Specification do not call up to mixbox.entities.Entity.from_obj. mixbox.entities.Entity.from_obj emits a Entity.created.from_obj signal. stixmarx.parser.MarkingParser creates its set of entities to use for processing by subscribing its _handle_entity_created callback to the Entity.created.from_obj signal. As a result, since this signal is not sent for any entities of and including stix-ciqidentity:Specification, these entities are not marked by stixmarx. I'm creating this as an issue against python-stix because the CIQIdentity3_0Instance implementation is contained in this project.

@emmanvg
Copy link
Contributor

emmanvg commented Oct 5, 2018

Hi @stevefranchak!

Thanks for reporting this. It appears the markings don't get applied to this extension because their children need binding objects and new API objects that implement the new TypedField changes. Thus, any CIQIdentity3_0Instance children would not be captured by stixmarx and will not be marked.

@stevefranchak
Copy link
Author

stevefranchak commented Oct 5, 2018

Thanks for responding, @emmanvg!

Is this something that your team is planning on updating? I could try figuring it out but wanted to check with you first. (And I'll make sure to include tests this time - that was my bad.)

@emmanvg
Copy link
Contributor

emmanvg commented Oct 5, 2018

@stevefranchak, unfortunately we don't see this as being high priority; instead we are focusing most of our efforts towards STIX 2. I would certainly appreciate a PR if you or anyone is willing to extend the current functionality.

Keep in mind stix-ciqidentity:CIQIdentity3_0Instance extension leverages the CIQ Specification which is extensive. Here is a link to the XSD schemas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants