Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow setting of core construct definition properties when idref is set #175

Open
bworrell opened this issue Aug 14, 2014 · 1 comment
Assignees

Comments

@bworrell
Copy link
Contributor

If an idref is set on an Indicator or other core construct, we unset the id_ property. It might be helpful to disallow the setting and exporting of other instance properties when idref is set, such as xsi:type. This would help address some of the concerns in #172

@bworrell bworrell added this to the v1.1.1.2 milestone Aug 14, 2014
@imjonsnooow
Copy link
Contributor

Question: should we go with a 'set it and forget it' method, or do we want to actively prohibit setting properties when idref is set? The easiest solution would be to check if idref is set in API objects' to_obj method, and not convert properties if idref is set. However, if we want to throw errors in these conditions, we'll have to modify all of the setters for all of the objects.

Any preference as to which route we should go? I'm guessing we'll want to go with the latter, so people aren't confused when they try to set properties and those properties are silently dropped...

@bworrell bworrell self-assigned this Oct 14, 2014
@bworrell bworrell modified the milestone: v1.1.1.2 Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants