resolve CI test breaking gasnet issues #6386

ct-clmsn · 2023-11-10T02:15:28Z

Fixes #6385

Proposed Changes

modify builders to use gasnet-mpi
modify the hpxrun script to use mpiexec when testing gasnet-mpi
update the gasnet environment logic to enable or disable gasnet

Any background context you want to provide?

the gasnet parcelport was merged into hpx and had started causing other parcelport tests to silently fail

Checklist

Not all points below apply to all pull requests.

I have added a new feature and have added tests to go along with it.
I have fixed a bug and have added a regression test.

codacy-production · 2023-11-10T07:04:47Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
+0.07%	∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`5ffdfbe`)	193075	164320	85.11%
Head commit (`8877fed`)	190055 (-3020)	161877 (-2443)	85.17% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6386)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

…varibles are defined

Pansysk75 · 2023-11-22T23:18:55Z

retest lsu

…e compiled application using srun; leave amudprun in the hpxrun script

Pansysk75 · 2023-12-11T17:29:31Z

retest

hkaiser · 2024-01-14T14:50:43Z

@Pansysk75, @ct-clmsn: what is the state of this PR? Did we ever manage to get the gasnet parcelport working properly?

ct-clmsn · 2024-01-14T15:01:34Z

@hkaiser I've had issues accessing the execution logs when the application fails runtime checks. I'll be pushing to complete this on a separate cluster at the top of the week.

hkaiser · 2024-01-14T15:35:10Z

@hkaiser I've had issues accessing the execution logs when the application fails runtime checks. I'll be pushing to complete this on a separate cluster at the top of the week.

Yes, the CSCS CDash is a bit unreliable, currently. We're in the process of moving it to Rostam.

codacy-production · 2024-02-22T05:31:00Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.44%	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`5ffdfbe`)	0	0	84.57%
Head commit (`b5694fc`)	189565 (+189565)	161149 (+161149)	85.01% (+0.44%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6386)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation}

hkaiser · 2024-04-28T16:31:26Z

@ct-clmsn could you please rebase this onto master? This will give us an understanding of what works (and what doesn't). Thanks!

ct-clmsn · 2024-04-28T16:41:24Z

@hkaiser will do; currently working with @constracktor on debugging this branch

hkaiser · 2024-05-03T15:27:19Z

@hkaiser will do; currently working with @constracktor on debugging this branch

Thanks. I'll leave this PR for now on track for the upcomming V1.10.0 release.

effort to resolve build breaking gasnet issues

4648b8f

ct-clmsn requested a review from hkaiser as a code owner November 10, 2023 02:15

ct-clmsn added 2 commits November 9, 2023 22:00

working on corrections to gasnet-mpi

85494d9

fixed logical error in cmake gasnet script

be6d3fe

ct-clmsn changed the title ~~effort to resolve build breaking gasnet issues~~ resolve CI test breaking gasnet issues Nov 10, 2023

added gasnet mpi-cflag

fb32dfc

hkaiser added type: enhancement category: parcel transport type: compatibility issue labels Nov 10, 2023

hkaiser added this to the 1.10.0 milestone Nov 10, 2023

ct-clmsn added 19 commits November 10, 2023 19:50

added missing MPI detection support to gasnet

5415d7e

check for add_library Mpi::mpi

b348e42

fix add_library Mpi::mpi

3e6a85d

continue work to fix Mpi::mpi

01c6a3a

fixed broken runwrapper argument handling by adding gasnet

6f746f0

gasnet cmake format isse

d64ae2c

Merge branch 'master' into gasnet_updates

b9ec34f

expanded compilation and include arguments

53b34d7

added escaped quotes around -fPIC arguments

38f50cb

added debug message

6154488

added gasnet_tools to mpi build

d9325e8

switching to pkgconfig for mpi check

e1e864f

switching to pkgconfig for mpi check

a28ca44

fixed logic error

116e7f5

fixed logic error

6c2970f

debugging pkgconfig

42d6c6d

adding debugging messages

e231a2a

adding debugging messages

731d06d

ordering corrections

c339b4b

ct-clmsn added 3 commits November 22, 2023 09:54

fixing variable naming issue

67ffe95

fixing situation where MPI is found but none of the associated cmake …

c77ff3b

…varibles are defined

fixing missing flag and redundant flags

fa4dd59

ct-clmsn added 15 commits November 24, 2023 15:01

rm'ing extraneous flags

6b27528

rm'ing extraneous quotes

4000c36

added manual pkgconfig commands

9c71cfe

forgot to remove from pkgconfig cflags and libs

08449fa

added default configuration mode

15b73a3

modified configuration ordering

6b20543

modified configuration ordering

de62809

switching from gasnet-mpi to gasnet-udp due to openmpi pkgconfig issues

0c73168

switching to gasnet-udp due to openmpi pkgconfig issues

0194f1d

switching to gasnet-udp due to openmpi pkgconfig issues

6041e26

changing how gasnet is deployed within hpxrun

87d15d0

changing how gasnet hpxrun.py to amudprun w/ssh support

094dba6

explicitly turn off gasnet conduits the user does not select; test th…

7a63a9a

…e compiled application using srun; leave amudprun in the hpxrun script

Merge branch 'STEllAR-GROUP:master' into gasnet_updates

3492614

refined amudprun support in the test code and in the hpxrun launcher

8877fed

updates to correct for gasnet on srun, removed amudprun support

b5694fc

hkaiser modified the milestones: 1.10.0, 1.11.0 May 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resolve CI test breaking gasnet issues #6386

resolve CI test breaking gasnet issues #6386

ct-clmsn commented Nov 10, 2023 •

edited

codacy-production bot commented Nov 10, 2023 •

edited

Pansysk75 commented Nov 22, 2023

Pansysk75 commented Dec 11, 2023

hkaiser commented Jan 14, 2024

ct-clmsn commented Jan 14, 2024

hkaiser commented Jan 14, 2024 •

edited

codacy-production bot commented Feb 22, 2024

hkaiser commented Apr 28, 2024

ct-clmsn commented Apr 28, 2024

hkaiser commented May 3, 2024

resolve CI test breaking gasnet issues #6386

Are you sure you want to change the base?

resolve CI test breaking gasnet issues #6386

Conversation

ct-clmsn commented Nov 10, 2023 • edited

Proposed Changes

Any background context you want to provide?

Checklist

codacy-production bot commented Nov 10, 2023 • edited

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Pansysk75 commented Nov 22, 2023

Pansysk75 commented Dec 11, 2023

hkaiser commented Jan 14, 2024

ct-clmsn commented Jan 14, 2024

hkaiser commented Jan 14, 2024 • edited

codacy-production bot commented Feb 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

hkaiser commented Apr 28, 2024

ct-clmsn commented Apr 28, 2024

hkaiser commented May 3, 2024

ct-clmsn commented Nov 10, 2023 •

edited

codacy-production bot commented Nov 10, 2023 •

edited

hkaiser commented Jan 14, 2024 •

edited