New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sum node conditional sampling #174

Open

braun-steven opened this issue Jan 9, 2024 · 0 comments

Assignees

Member

braun-steven commented Jan 9, 2024

The current conditioning on the child_lls is wrong: (a) log-space is missing and (b) the posterior is not normalized.

SPFlow/spflow/modules/node/sum.py

Line 320 in 794a8dd

sampling_weights = node.weights + child_lls[sampling_ctx.instance_ids]

The text was updated successfully, but these errors were encountered:

braun-steven self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment