Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit conversion in P452 propagation model #42

Open
edgar-souza opened this issue Jun 26, 2017 · 0 comments
Open

Unit conversion in P452 propagation model #42

edgar-souza opened this issue Jun 26, 2017 · 0 comments
Assignees

Comments

@edgar-souza
Copy link
Contributor

  • SHARC version: 0.0.1
  • Python version: 3.5
  • Operating System: Windows

Description

Frequency and distance units should be stored in MHz and meters, respectively, in order to keep consistency with other parts of simulator. This is not necessarily a bug (since code is working fine), but it has to be fixed in the whole P.452 implementation.

What I Did

This issue was found after code reviewing. Examples: lines 19 and 20 of file propagation_gases_attenuation.py:

d = np.asarray(kwargs["distance"]) #Km
f = np.asarray(kwargs["frequency"]) #GHz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
SHARC development
Awaiting triage
Development

No branches or pull requests

2 participants