Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cython 3 regressions #1524

Open
heinezen opened this issue Jul 24, 2023 · 7 comments
Open

Cython 3 regressions #1524

heinezen opened this issue Jul 24, 2023 · 7 comments
Labels
code quality Does not alter behavior, but beauty of our code improvement Enhancement of an existing component just do it You can start working on this, there should be nothing left to discuss lang: cython Implemented using Cython code

Comments

@heinezen
Copy link
Member

We added Cython 3.0.0 support in #1523 but we still have to check for regressions introduced by the new version. Cython 3 is a huge update, so there could be several implications for speed and functionality.

We'll have to check each cython module and can compare the results in this issue.
@heinezen heinezen added improvement Enhancement of an existing component lang: python Done in Python code code quality Does not alter behavior, but beauty of our code just do it You can start working on this, there should be nothing left to discuss labels Jul 24, 2023
@zoli111

This comment was marked as resolved.

Sign in to view
@heinezen

This comment was marked as resolved.

Sign in to view
@zoli111

This comment was marked as resolved.

Sign in to view
@heinezen

This comment was marked as resolved.

Sign in to view
@zoli111

This comment was marked as resolved.

Sign in to view
@heinezen

This comment was marked as resolved.

Sign in to view
@heinezen
Copy link
Member Author

@zoli111 I've updated our docker and CI builds as well as the build requirements to Cython 0.29.31. Also fixed the missing toml libraries :)

@heinezen heinezen added lang: cython Implemented using Cython code and removed lang: python Done in Python code labels Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Does not alter behavior, but beauty of our code improvement Enhancement of an existing component just do it You can start working on this, there should be nothing left to discuss lang: cython Implemented using Cython code
Projects
openage code quality
Status: To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heinezen @zoli111