New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization on meshes with cutting planes #969
Comments
Excellent bug report @jadie1 , small dataset included and instructions to reproduce. @HeavenlyBerserker , for reference, it's stuck here:
|
@HeavenlyBerserker oh okay, so in theory if the meshes and cutting planes made sense then the bug would not exist? Joe needs to optimize with cutting planes on unclipped femur meshes, I was trying to provide him with an example xml. So I just made up cutting planes and used femur meshes, but if I am more careful about it then it should work? |
Yes, I tried cutting planes that don't get violated but ran into the spacing problem, but it works. If you can put all the femora in the same general area and adjust the cutting planes to be reasonable, I see no reason this shouldn't work, especially considering you're only using one cutting plane. |
Okay yep confirmed no bug when I used this data: test.zip Thanks for helping me understand @HeavenlyBerserker |
We've chopped up some meshes successfully and there are unit tests for this (MeshTests, PythonTests, and shapeworksTests).
Absolutely! Thank you!! |
@HeavenlyBerserker , is there any way this condition can be detected and an exception raised or error message? I would really prefer that to hanging or crashing. Also, is there a way we can verify prior to running? See #910 . |
Hmm, it should be possible to check if at least one of the mesh/image points of any input satisfies the constraint. Not fool-proof, but should work 99.9% of the time. |
When you optimize on meshes with cutting planes, optimization seemingly freezes after initialization. No error is thrown but it gets stuck.
To test:
shapeworks optimize --name correspondence_1024.xml
Note that if the cutting plane is removed from the xml, optimization runs as expected.
The text was updated successfully, but these errors were encountered: