Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParticleSystem and Optimize classes should be in shapeworks namespace #431

Closed
cchriste opened this issue Mar 7, 2020 · 4 comments
Closed

Comments

@cchriste
Copy link
Contributor

cchriste commented Mar 7, 2020

, etc.

@sheryjoe
Copy link
Contributor

@akenmorris @medakk has this been resolved?

@sheryjoe sheryjoe added this to the 6.0 Leftover milestone Feb 15, 2021
@medakk
Copy link
Contributor

medakk commented Feb 15, 2021

No, everything is still in the itk namespace.

@sheryjoe sheryjoe modified the milestones: 6.0 Leftover, 6.1 Release (May 2021) Feb 15, 2021
@akenmorris
Copy link
Contributor

akenmorris commented Feb 17, 2021

As we un-ITK these classes we will move them out. For example, the Optimize and Sampler classes are not longer ITK objects and now live in the shapeworks namespace.

For many of these classes, ParticleGradientDescentPositionOptimizer for example, it doesn't make sense to change the namespace without making them non-ITK classes. Otherwise you will have to add the itk namespace to many of the types used.

@akenmorris
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants