Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepSSM: validation/training split modification enforcement #2171

Open
JakeWags opened this issue Dec 4, 2023 · 0 comments
Open

DeepSSM: validation/training split modification enforcement #2171

JakeWags opened this issue Dec 4, 2023 · 0 comments
Assignees
Labels
Interface: Studio related to ShapeWorks Studio

Comments

@JakeWags
Copy link
Contributor

JakeWags commented Dec 4, 2023

Currently the user is able to run DeepSSM augmentation with set split percentages (ie: 25%, 15%) and then change those values in the studio UI and run training, which will pull the updated values. This means there can be a discrepancy between the two tasks split percentages, causing unintended behavior and potentially errors.

There should be some form of enforcement on when the split values are saved. Simply passing the job type to store_params and adding a condition to only save if the task is Augmentation could suffice

@JakeWags JakeWags added the Interface: Studio related to ShapeWorks Studio label Dec 4, 2023
@akenmorris akenmorris self-assigned this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interface: Studio related to ShapeWorks Studio
Projects
None yet
Development

No branches or pull requests

2 participants