New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShapeWorks 6.2 Testing #1509
Comments
This comment has been minimized.
This comment has been minimized.
I can't seem to edit above, but I have OpenSUSE 15.2 and Windows 10 that I can test on. |
Thanks Penny. I'm not sure why you cannot edit, especially since you can be assigned! But please keep commenting and one of us can add the details you share above. |
Should we be testing RC3? |
Yes. I am working on automated verification though. |
Hi Jadie, I think it would be really helpful to have a demonstration of how to manually verify a use case is correct by looking at the results in Studio. If you have expertise doing something like this, would it be possible to record a short video demonstrating and explaining how one might go about this? This aid can help everyone to better ensure not only that the use cases complete, but that their results seem correct (or incorrect). |
@cchriste All of the use cases have updated results in the documentation. I would just recommend running the use cases then comparing what you see in studio with the snapshots and videos of expected output in the documentation. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I will create a PR for the the typos in ellipsoid pca and multiple domains. |
In the joint dataset, only one ellipsoid changes rotation and or size w.r.t to the first one. So one of the ellipsoids will not have any modes of variation. I am not sure if you are referring to this. |
It will be active if there are groups present (e.g. group_<> columns). I think maybe a tooltip or message why it's greyed out could be helpful. I think it's in the right place. |
RC6 on linux:
|
RC6 on Mac: [ PASSED ] : 26 seconds : ellipsoid_fd --tiny_test 100.00% tests passed, 0 failed out of 40 Total Test time: 65601 seconds |
RC6 on Windows:
|
RC8 Windows: Testing Results:The following use cases passed (40) 100.00% tests passed, 0 failed out of 40 Total Test time: 71674 seconds |
@akenmorris are we ready to release 6.2? |
The use cases appear to all work according to the verify script. I have not examined the shape models in Studio yet. Someone needs to re-test all of the jupyter notebooks on all three platforms. We also need to resolve #1580. |
@jadie1 @iyerkrithika21 could you re-test the notebooks? |
Linux RC8: Testing Results:The following use cases passed (40) 100.00% tests passed, 0 failed out of 40 Total Test time: 39113 seconds |
Mac RC8: Testing Results:The following use cases passed (40) 100.00% tests passed, 0 failed out of 40 Total Test time: 65453 seconds |
I can test the notebooks on Mac |
You might hold off testing notebooks until after #1580 is resolved. Fixing all the incompatible mess of versions we have of conda/pip packages may end up breaking things. The notebooks would be the most likely to break since they use these extremely brittle packages like pyvista. |
Mac RC9: Testing Results:The following use cases passed (40) 100.00% tests passed, 0 failed out of 40 Total Test time: 69289 seconds |
RC9 on Linux: Testing Results:The following use cases passed (40) 100.00% tests passed, 0 failed out of 40 Total Test time: 37005 seconds |
6.2 has been released. Thanks everyone! |
TODO: clean up this note to remove the "done" portions below.
@sheryjoe there are several people missing from our repo who attend our weekly meetings.
Please edit and add a ✅ indicating success and ❌ indicating failure or 🕒 for a test in progress with your username when you complete a task for a given platform. Also, go ahead and add new tasks that might not already be on here.
When a test fails, please add a github issue:
bug
, etc)Please use the most recent release candidate for all testing (be careful which
shapeworks
is in your$PATH
).The most recent is RC9:
https://github.com/SCIInstitute/ShapeWorks/releases/tag/v6.2.0-rc9
Example:
Systems chart
Instructions for running and testing items
Testing modes:
General instructions
Notebooks
ShapeWorks/Examples/Python/notebooks/tutorials
on terminal/CMD.jupyter notebook
command.UseCases
ShapeWorks/Examples/Python/ on terminal/CMD
or on your favorite IDE that runs python.python RunUseCase.py --use_case <use_case>
command, where <use_case> is replaced by the command given. For instancepython RunUseCase.py --use_case femur
, orpython RunUseCase.py --use_case femur --groom_images
.Studio
ShapeWorks/Examples/Python/<item>
on terminal/CMD, where "" is the item you're testing.ShapeWorksStudio <item>.xlsx
.Studio: MeshGrooming
ShapeWorksStudio
, or open ShapeWorksStudio somehow.Ok, now the real thing!
*(not sure where to find results in Use Cases documentation for comparison)
* Edit deep_ssm.py so that
num_samples = 3
on line 76 and"epochs": 3,
on line 132, otherwise it will take upwards of two days.Please keep comments on this issue to a minimum. Let's try to keep the status in the table and not in the comments.
The text was updated successfully, but these errors were encountered: