Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC12 documentation for Examples #1349

Closed
patkins opened this issue Jun 24, 2021 · 2 comments · Fixed by #1350
Closed

RC12 documentation for Examples #1349

patkins opened this issue Jun 24, 2021 · 2 comments · Fixed by #1350
Assignees

Comments

@patkins
Copy link

patkins commented Jun 24, 2021

#1273 The install worked well (I was able to run a use case and notebook tutorial), however it seems the commands for the use cases have changed, but have not been updated in the Windows_README.txt

4. Run one of the included use cases. To list them all, run: `python RunUseCase.py --help`.
`python RunUseCase.py --use_case ellipsoid_fd`. 

Anaconda console output:

(shapeworks) C:\Users\penny\Documents\shapeworks\Examples\Python>python RunUseCase.py --use_case ellipsoid
Using shapeworks module from C:\Users\penny\miniconda3\envs\shapeworks\lib\site-packages\shapeworks\__init__.py
Using shapeworks from c:\Program Files\ShapeWorks\bin\shapeworks.EXE
usage: RunUseCase.py [-h] [--use_subsample] [--num_subsample NUM_SUBSAMPLE]
                     [--interactive] [--skip_grooming] [--groom_images]
                     [--use_single_scale] [--tiny_test]
                     {ellipsoid,ellipsoid_evaluate,ellipsoid_mesh,ellipsoid_fd,ellipsoid_cut,ellipsoid_pca,ellipsoid_multiple_domain,ellipsoid_multiple_domain_mesh,lumps,left_atrium,femur,femur_mesh,femur_cut,deep_ssm,supershapes_1mode_contour,thin_cavity_bean}
RunUseCase.py: error: unrecognized arguments: --use_case

(shapeworks) C:\Users\penny\Documents\shapeworks\Examples\Python>python RunUseCase.py ellipsoid

There is also no feedback for the user if the folder doesn't exist (i.e. has not yet been unzipped) in the notebook getting-started-with-exploring-segmentations.ipynb, this is super minor, but may help novice users.

@patkins patkins changed the title RC12 documentation Windows_README.txt RC12 documentation for Examples Jun 24, 2021
@cchriste
Copy link
Contributor

Good catch, Penny. Thank you!

Devs: I've created misc_61 branch for little stuff like this so we don't have to wrangle a bunch more PRs but can instead get everything that doesn't modify functionality in with one later today.

@cchriste cchriste added this to the 6.1 Release (June 2021) milestone Jun 24, 2021
@cchriste cchriste linked a pull request Jun 24, 2021 that will close this issue
@cchriste cchriste added the QA label Jun 24, 2021
@cchriste cchriste self-assigned this Jun 24, 2021
@sheryjoe
Copy link
Contributor

@cchriste is this resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants