Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Additional padding below dynamic page header #11862

Closed
do-oel opened this issue Apr 30, 2024 · 4 comments · Fixed by #11961
Closed

Bug: Additional padding below dynamic page header #11862

do-oel opened this issue Apr 30, 2024 · 4 comments · Fixed by #11961

Comments

@do-oel
Copy link

do-oel commented Apr 30, 2024

Is this a bug, enhancement, or feature request?

Bug

Describe your proposal.

When using the dynamic page, an empty container appears below the page header although the subheader is set to [collapsible]="false".

image

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

Current and below.

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Component: fd-dynamic-page

@InnaAtanasova
Copy link
Contributor

Hi Dominik, I am not able to reproduce this. Can you check in the Stackblitz example: https://stackblitz.com/run?file=src%2Fapp%2Fplatform-dynamic-page-example.component.html

@pawelkarwat
Copy link

Hi Inna,

Unfortunately, I can't access StackBlitz. I will try to describe our implementation. During the implementation, we used the fd-message-subheader, to which we add the fd-message-strip component if there is an error. When the fd-message-subheader is empty, it adds additional padding that is not expected. Would it be possible for Fundamental to set the padding to 0 when we insert an empty fd-message-subheader component? I'm not sure if this is reported correctly as a bug.

@InnaAtanasova
Copy link
Contributor

Hi @pawelkarwat would this solve the problem: #11961? Thanks

@pawelkarwat
Copy link

@InnaAtanasova Exactly, this task should solve our problem. Thanks for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants